Skip to content

🛡️ Sentinel: [CRITICAL] Fix LaTeX Injection RCE and DoS - #434

Open
anchapin wants to merge 3 commits into
mainfrom
sentinel/fix-pdf-rce-dos-7127278171201720126
Open

anchapin wants to merge 3 commits into
mainfrom
sentinel/fix-pdf-rce-dos-7127278171201720126

Conversation

@anchapin

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL\n\n💡 Vulnerability: PDF compilation commands (pdflatex and pandoc) did not disable shell escape and lacked timeouts.\n\n🎯 Impact: An attacker could inject malicious LaTeX code to execute arbitrary shell commands (RCE) via \write18 or cause a Denial of Service (DoS) via infinite compilation loops.\n\n🔧 Fix: Added -no-shell-escape flag to pdflatex and --pdf-engine-opt=-no-shell-escape to pandoc. Wrapped communicate() in a 30-second timeout block that cleans up the process if it hangs.\n\n✅ Verification: Verified the fixes in cli/pdf/converter.py and cli/generators/cover_letter_generator.py and ran the full test suite to ensure no regressions were introduced.


PR created automatically by Jules for task 7127278171201720126 started by @anchapin

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

google-labs-jules Bot and others added 2 commits July 27, 2026 03:14
Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant