Skip to content

feat: Add Payment status for validate payment for Sylius 2 private#252

Open
Benjamin-Freoua-Alma wants to merge 7 commits into
feature/3.0from
feature/const-of-payment-status-for-validate-payment
Open

feat: Add Payment status for validate payment for Sylius 2 private#252
Benjamin-Freoua-Alma wants to merge 7 commits into
feature/3.0from
feature/const-of-payment-status-for-validate-payment

Conversation

@Benjamin-Freoua-Alma

Copy link
Copy Markdown
Member

Reason for change

Linear task
I don't create ticket.

I tried to run the Sylius 2 private environment, but I encountered errors. Some payment validation code was missing.

I didn't see a pull request (PR) created for this, so I created one just in case. However, if another PR already exists, it will likely need to be replaced if there's more content.

Code changes

Add missing code for payment validation with payment status for the Sylius 2 private environment

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma
Benjamin-Freoua-Alma requested a review from a team as a code owner June 20, 2026 09:47
Comment thread src/Client/Domain/Entity/Payment.php Outdated
protected array $optionalFields = [];
protected array $optionalFields = [
'processingStatus' => 'processing_status',
];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as said below, the field is not optional

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved in requiredFields

Comment thread src/Client/Domain/Entity/Payment.php Outdated
@Benjamin-Freoua-Alma
Benjamin-Freoua-Alma requested a review from mgu July 8, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants