Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
code_searchparsing for filenames containing colons and other special characters.git grepoutput was parsed using delimiter-sensitive text output, which could cause characters in filenames to be interpreted as part of the match metadata. Binary match notices could also interfere with result parsing and matching-file counts.This change:
git grepoutput so filenames can be parsed without relying on special characters as separators;Type of Change
How Has This Been Tested?
go test ./internal/toolmake checkmake testmake buildThe regression tests cover special-path parsing and binary-result handling, including the result-limit case that previously produced an incorrect matching-file count.
Checklist
go fmt,go vet)AI Disclosure
I used ChatGPT with GPT-5.6 Sol to assist with debugging and language/writing support. I reviewed the suggested changes and the resulting code myself, and the commit contains no AI attribution trailer.
Related Issues
N/A