Skip to content

KL Clipping may be error #2

Description

@zhengzangw

def _kl_clip_and_update_grad(self, updates, lr):

The KL clipping should be $vFv^T$, here it seems to calculate $vF^{-1}v^T$.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions