Bump pako and @types/pako#381
Conversation
kevinelliott
left a comment
There was a problem hiding this comment.
Verdict: Hold (Blocker)
This bumps pako from ^1.0.11 -> ^2.1.0 (and @types/pako 1.x -> 2.x). This is a major version bump and is intentionally pinned to 1.x in this repo because pako 2.x has CJS/Jest interop issues (ESM-only entry points, breaking changes around Inflate/Deflate API, dropped binary-string/Array support). This library publishes both CJS and ESM bundles via tsup, so we need the 1.x line.
CI status: All build matrix jobs (20.x / 22.x / 24.x / latest) are failing on this PR, consistent with the pako 2.x compatibility concern.
Recommendation: Close this PR and tell Dependabot to ignore the pako major:
@dependabot ignore this major version
If/when we want to migrate to pako 2.x, it should be a deliberate, separate PR that updates the import sites and Jest config to handle the ESM build, not an automated dep bump.
|
@dependabot rebase |
d29c394 to
c38cad7
Compare
|
@dependabot rebase |
Bumps [pako](https://github.com/nodeca/pako) and [@types/pako](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/pako). These dependencies needed to be updated together. Updates `pako` from 1.0.11 to 2.1.0 - [Changelog](https://github.com/nodeca/pako/blob/master/CHANGELOG.md) - [Commits](nodeca/pako@1.0.11...2.1.0) Updates `@types/pako` from 1.0.7 to 2.0.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/pako) --- updated-dependencies: - dependency-name: "@types/pako" dependency-version: 2.0.4 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: pako dependency-version: 2.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c38cad7 to
6677e93
Compare
Bumps pako and @types/pako. These dependencies needed to be updated together.
Updates
pakofrom 1.0.11 to 2.1.0Changelog
Sourced from pako's changelog.
Commits
3c062162.1.0 releasedb61f524dist rebuild23c773eUpdate comments in tree.js for Babel compatibility174a1d1Ensure backward compatibility forheaders.extra77f1c17Don't bother computing check value after successful inflateSync().a194382Fix a bug that can crash deflate on some input when using Z_FIXED.8a1cdadFix deflateEnd() to not report an error at start of raw deflate.4dd6658Fix bug when window full in deflate_stored().b579434Limit hash table inserts after switch from stored deflate.2326b42Permit a deflateParams() parameter change as soon as possible.Updates
@types/pakofrom 1.0.7 to 2.0.4Commits