chore(low-code): remove unused SubstreamPartitionRouter._migrate_child_state_to_parent_state - #1100
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@lazebnyi/remove-dead-migrate-child-state#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch lazebnyi/remove-dead-migrate-child-statePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
PyTest Results (Full)4 161 tests 4 149 ✅ 12m 34s ⏱️ Results for commit 44992d3. |
What
Remove
SubstreamPartitionRouter._migrate_child_state_to_parent_state— it has no callers anywhere in the codebase.Why
It's dead code left over from the pre-concurrent implementation: parent state is now seeded at stream-construction time in
ModelToComponentFactory._instantiate_parent_stream_state_manager. Leaving it around is misleading — the analysis in #1067 anchored on it as a suspected root cause, and #1079 independently noted it has no callers.Test
grep -rn _migrate_child_state_to_parent_state— no remaining references (production or tests)pytest unit_tests/sources/declarative/partition_routers/— 68 passed