Skip to content

chore(low-code): remove unused SubstreamPartitionRouter._migrate_child_state_to_parent_state - #1100

Open
Serhii Lazebnyi (lazebnyi) wants to merge 1 commit into
mainfrom
lazebnyi/remove-dead-migrate-child-state
Open

chore(low-code): remove unused SubstreamPartitionRouter._migrate_child_state_to_parent_state#1100
Serhii Lazebnyi (lazebnyi) wants to merge 1 commit into
mainfrom
lazebnyi/remove-dead-migrate-child-state

Conversation

@lazebnyi

Copy link
Copy Markdown
Contributor

What

Remove SubstreamPartitionRouter._migrate_child_state_to_parent_state — it has no callers anywhere in the codebase.

Why

It's dead code left over from the pre-concurrent implementation: parent state is now seeded at stream-construction time in ModelToComponentFactory._instantiate_parent_stream_state_manager. Leaving it around is misleading — the analysis in #1067 anchored on it as a suspected root cause, and #1079 independently noted it has no callers.

Test

  • grep -rn _migrate_child_state_to_parent_state — no remaining references (production or tests)
  • pytest unit_tests/sources/declarative/partition_routers/ — 68 passed

@lazebnyi
Serhii Lazebnyi (lazebnyi) requested a review from a team as a code owner July 31, 2026 23:03
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@lazebnyi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99ea5d3c-813f-4cbf-b8f1-e200c58961b9

📥 Commits

Reviewing files that changed from the base of the PR and between e79d50e and 44992d3.

📒 Files selected for processing (1)
  • airbyte_cdk/sources/declarative/partition_routers/substream_partition_router.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@lazebnyi/remove-dead-migrate-child-state#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch lazebnyi/remove-dead-migrate-child-state

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@github-actions

Copy link
Copy Markdown

PyTest Results (Fast)

4 158 tests  ±0   4 146 ✅ ±0   7m 49s ⏱️ +2s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 44992d3. ± Comparison against base commit e79d50e.

@github-actions

Copy link
Copy Markdown

PyTest Results (Full)

4 161 tests   4 149 ✅  12m 34s ⏱️
    1 suites     12 💤
    1 files        0 ❌

Results for commit 44992d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants