fix(manifest-server): serve /health and /capabilities without 307 redirect - #1091
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
fix(manifest-server): serve /health and /capabilities without 307 redirect#1091devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1785421712-manifest-server-health-no-redirect#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1785421712-manifest-server-health-no-redirectPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Helm chart v2, kubelet probes hit
GET /healthon the manifest-server and get a307 Temporary Redirectto/health/(FastAPI's defaultredirect_slashes=True), doubling probe request volume and polluting logs/metrics with 307s. Root cause: the health router registers only the trailing-slash path (APIRouter(prefix="/health")+@router.get("/")).Fix: register an additional no-trailing-slash route on the same handlers, hidden from the OpenAPI schema to avoid duplicate spec entries:
The sibling
capabilitiesrouter had the sameprefix+"/"pattern, so it gets the identical treatment for consistency (getCapabilitiesoperation unchanged). Themanifestrouter's versioned paths are untouched. No change to response bodies or status codes;/health/and/capabilities/keep working.Resolves https://github.com/airbytehq/oncall/issues/13203:
Upstream community report: airbytehq/airbyte#83263
Test Coverage
unit_tests/manifest_server/routers/test_health.py: assertsGET /healthreturns 200 (withfollow_redirects=False, so a 307 would fail) andGET /health/still returns 200.test_capabilities.py:GET /capabilitiesreturns 200 without redirect.poetry run pytest unit_tests/manifest_server -q→ 48 passed; ruff check/format and mypy clean.Link to Devin session: https://app.devin.ai/sessions/0726083ae0bc474abb31094d82a8f933