review(ted): complete PR #65 grading contract - #85
Draft
TabsPhasers wants to merge 15 commits into
Draft
Conversation
Based on aiming-lab#1 (TED mirror by @shanjiaming). Adds the reviewer grading contract and fixes task-definition issues surfaced in review. Verifiers (sites/ted/verify/): verify_lib.py + verify_0..17.py — deterministic-first (nav-evidence + answer match + DB after-state), LLM utilities anchored on frozen ground truth. verifier_path + judge_rubric recorded in tasks.jsonl. Validated: no-op FAILs 18/18, correct solve PASSes 18/18, wrong answers/actions FAIL. Task fixes (sites/ted/tasks.jsonl): - Add demo credentials to account-bound tasks (1/4/7/9/12). - De-shortcut prior-knowledge-answerable tasks: TED--5 -> exact title; TED--17 -> event month (Nov 2025) instead of city (Atlanta). - TED--7: retarget from TED Countdown Summit 2025 (Alice is seed-registered -> no-op) to TED2026.
- verify_11: require /talks? (filter listing) so opening a /talks/<slug> detail page alone no longer satisfies the 'used filters' check. - extract_ints: word-boundary match so a duration check can't be satisfied by an incidental integer (e.g. '15k' views).
TabsPhasers
force-pushed
the
review/ted-pr65-remediation-public
branch
from
September 6, 2026 14:12
2b25f0d to
18fa53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft pull request is the reviewer-authored remediation package for WebHarbor PR #65. It completes and hardens the TED task grading contract that was reviewed against the remote PR head
065e39a4e1bf33e61902abdfb3e9d35f1e62428e.The original PR remains unchanged. Its remote head contains 18 tasks and 18 verifiers; this draft adds the missing two high-difficulty comparison tasks and carries the fixes required by the Review Environment Skill. Maintainers can review this as a replacement/companion PR before deciding how to land the remediation.
What changed
TED--18andTED--19, two filtered, multi-page view-count comparison tasks with dedicated deterministic verifiers and judge rubrics.sites/ted/tasks.jsonlhas noanswerkey and contains only the permitted task and grading-contract fields.Review outcome for PR #65
The correct status for the current remote PR head is REQUEST_CHANGES until equivalent changes are present on that PR. The remote head has the following blocking gaps:
/talkslisting.Novemberwithout requiring theTEDNext 2025event/year.Validation
597623a2f32898afa12e3bbeda15520f559aa7c7was checked directly and returned HTTP 200.The full-environment smoke used the existing local
webharbor:ted-reviewimage. A fresh source rebuild of the exact remote PR head was not established because unrelated local asset locks affected the earlier build; CI should remain the final reproducibility check.Evidence
Review contract
Each task has one verifier under
sites/ted/verify/verify_<N>.pyand a correspondingjudge_rubricinsites/ted/tasks.jsonl. The verifier is deterministic-first and checks navigation, visible task facts, final output, and SQLite state where applicable. The LLM judge is secondary; no-op failure and state-delta checks are retained as independent controls.Checklist