Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Performance report — this PR vs base branch🔴 6 regressions · 🟢 4 improvements across 77 scenarios.
A metric counts as changed only past per-metric thresholds sized to measured shared-runner variance on identical code: interaction latency ±10% and 16ms (measured in 8ms steps), frame times ±30%, long-task/LoAF sums ±10% and 500ms, memory ±25% and 512KB / 60 nodes, process CPU ±20% and 10 points, GPU-process CPU ±20% and 3 points, animation ticks ±20% and 3/s, draws/tick ±20% and 0.05, hardware GPU ±20% and 10 points, compositor production ±20% and 3fps / 5 duty-cycle points, composited layers ±20% and 2 layers / 0.5 viewport areas, rendering stages ±20% and 1ms; any ms metric with a ≥100ms baseline needs ±30%. All 73 standard scenarios (full numbers)
All 5 animation scheduling controls (full numbers)
Commit 24dc23f · full reports in the |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Summary
Testing
nr buildnr test: 356 unit tests, 909 cross-framework E2E tests, and 73 performance tests passed; 1 unrelated Three Fiber E2E case passed on retrynr lint: 0 warnings, 0 errorsnr typechecknr formatWalkthrough
comment_composer_balanced_compact_demo.mp4
To show artifacts inline, enable in settings.
Summary by cubic
Improves the
react-grabcomment composer with a 160ms opacity-only fade at final size, a compact starting input, and spacing scoped to the composer. This removes sizing jitter and makes growth and spacing predictable.280px; textarea min16px, max95px; headerpt-1 pb-0.5; bottom stacks input and submit with a small gap; submit moved below input and explicitly18pxwith a matching row height.comment-composer-enterfade with duration set via constants; textarea height transitions180msviaautoResizeTextareausing requestAnimationFrame with per-element pending-frame cancellation for line-by-line growth..focus()); E2E asserts fade-only enter (no transform/clip/size keyframes), compact start with focus, line-by-line expansion, submit below input with small control, and a height transition.Written for commit 24dc23f. Summary will update on new commits.