Version Packages - #55
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
agoda-devfeedback-common@2.2.0
Minor Changes
83413f6: Make the Vite and Rsbuild build-time metrics apples-to-apples.
timeTakenwasbuildEnd - buildStart, and Rollup'sbuildEndfires when the module graph is complete — beforerenderChunk,generateBundleandwriteBundle. Minification and emitting assets were excluded: 18% of the build under esbuild, 64% under terser, on a 301-module project. It is now measured throughcloseBundle, matching what Rsbuild'sstats.endTime - stats.startTimealready covered. The transform phase is still reported, as a newtransformTimeMsfield, instead of being the headline number.phase: 'clientready'as acommandevent, timed from dev server start so it shares an origin with Vite's. It previously existed only as aclientReadyentry insidedevFeedback[], timed withperformance.now()— i.e. from page navigation, excluding everything before the browser opened the page — which was not comparable with Vite's number. The browser-relative values are unchanged and still indevFeedback[], and are also attached to the new event asdomContentLoadedMs/firstContentfulPaintMs.prebundledflag can now actually reporttrue. It compared the mtime ofnode_modules/.vite/deps/_metadata.jsonatlistening, but dependency prebundling is triggered by the first browser request and has not run at that point — so it reportedfalseon a warm cache and nothing on a cold one, never observing the cost it exists to measure. It is now sampled on theclientreadyreport, and moves from thedevserverevent to theclientreadyevent with it.agoda-devfeedback-rsbuild@2.2.0
Minor Changes
83413f6: Make the Vite and Rsbuild build-time metrics apples-to-apples.
timeTakenwasbuildEnd - buildStart, and Rollup'sbuildEndfires when the module graph is complete — beforerenderChunk,generateBundleandwriteBundle. Minification and emitting assets were excluded: 18% of the build under esbuild, 64% under terser, on a 301-module project. It is now measured throughcloseBundle, matching what Rsbuild'sstats.endTime - stats.startTimealready covered. The transform phase is still reported, as a newtransformTimeMsfield, instead of being the headline number.phase: 'clientready'as acommandevent, timed from dev server start so it shares an origin with Vite's. It previously existed only as aclientReadyentry insidedevFeedback[], timed withperformance.now()— i.e. from page navigation, excluding everything before the browser opened the page — which was not comparable with Vite's number. The browser-relative values are unchanged and still indevFeedback[], and are also attached to the new event asdomContentLoadedMs/firstContentfulPaintMs.prebundledflag can now actually reporttrue. It compared the mtime ofnode_modules/.vite/deps/_metadata.jsonatlistening, but dependency prebundling is triggered by the first browser request and has not run at that point — so it reportedfalseon a warm cache and nothing on a cold one, never observing the cost it exists to measure. It is now sampled on theclientreadyreport, and moves from thedevserverevent to theclientreadyevent with it.Patch Changes
agoda-devfeedback-vite2@2.2.0
Minor Changes
83413f6: Make the Vite and Rsbuild build-time metrics apples-to-apples.
timeTakenwasbuildEnd - buildStart, and Rollup'sbuildEndfires when the module graph is complete — beforerenderChunk,generateBundleandwriteBundle. Minification and emitting assets were excluded: 18% of the build under esbuild, 64% under terser, on a 301-module project. It is now measured throughcloseBundle, matching what Rsbuild'sstats.endTime - stats.startTimealready covered. The transform phase is still reported, as a newtransformTimeMsfield, instead of being the headline number.phase: 'clientready'as acommandevent, timed from dev server start so it shares an origin with Vite's. It previously existed only as aclientReadyentry insidedevFeedback[], timed withperformance.now()— i.e. from page navigation, excluding everything before the browser opened the page — which was not comparable with Vite's number. The browser-relative values are unchanged and still indevFeedback[], and are also attached to the new event asdomContentLoadedMs/firstContentfulPaintMs.prebundledflag can now actually reporttrue. It compared the mtime ofnode_modules/.vite/deps/_metadata.jsonatlistening, but dependency prebundling is triggered by the first browser request and has not run at that point — so it reportedfalseon a warm cache and nothing on a cold one, never observing the cost it exists to measure. It is now sampled on theclientreadyreport, and moves from thedevserverevent to theclientreadyevent with it.Patch Changes
agoda-devfeedback-webpack@2.0.11
Patch Changes