Skip to content

fix package-level runtime inputs - #715

Open
asalloum5 wants to merge 3 commits into
mainfrom
CEXT-6697-fix-package-level-log-inputs
Open

fix package-level runtime inputs#715
asalloum5 wants to merge 3 commits into
mainfrom
CEXT-6697-fix-package-level-log-inputs

Conversation

@asalloum5

@asalloum5 asalloum5 commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have read the DEVELOPMENT document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Alex Salloum Alex Salloum
fix package-level runtime inputs
0298bee 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 16c60e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added without-changeset The PR does not contain a Changeset file pkg: aio-commerce-lib-app Includes changes in `packages/aio-commerce-lib-app` private-pkg: scripting-utils Includes changes to `packages-private/scripting-utils` labels Oct 1, 2026
iivvaannxx
iivvaannxx reviewed Oct 2, 2026
View reviewed changes

@iivvaannxx iivvaannxx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is the goal of this PR? What is it trying to fix?

Just a bit confused because it's also messing with normal action inputs and the PR is about something package-level.

Comment thread packages-private/scripting-utils/source/yaml/codegen.ts Outdated
Comment on lines +110 to +112
const legacyLogLevel =
packageInputs?.LOG_LEVEL === "$LOG_LEVEL" &&
existingAction?.getIn(["inputs", "LOG_LEVEL"]) === "$LOG_LEVEL";

@iivvaannxx iivvaannxx Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generic helper, it should not know anything about specific variables. Put that one layer above in the code (probably lib-app).

@obarcelonap implemented a way of removing "legacy" variables in generated actions if you are in need for that. See #712

@asalloum5 asalloum5 Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

Alex Salloum and others added 2 commits October 2, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iivvaannxx iivvaannxx iivvaannxx left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pkg: aio-commerce-lib-app Includes changes in `packages/aio-commerce-lib-app` private-pkg: scripting-utils Includes changes to `packages-private/scripting-utils` without-changeset The PR does not contain a Changeset file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asalloum5 @iivvaannxx