chore!: Remove deprecated cmake options#5583
Merged
Merged
Conversation
Removed deprecated options for CUDA and Python bindings in CMake configuration.
benjaminhuth
changed the title
andiwand
previously approved these changes
Jun 12, 2026
andiwand
left a comment
andiwand
left a comment
Contributor
There was a problem hiding this comment.
thanks! I would have forgotten about these
Contributor
andiwand
previously approved these changes
Jun 15, 2026
andiwand
reviewed
Jun 15, 2026
This reverts commit 89cfbcf.
andiwand
approved these changes
Jun 15, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed deprecated options for CUDA and Python bindings in CMake configuration. Not sure if strictly breaking according to our policy, but now is a good point to remove those.