Skip to content

feat: deprecate infallible body stream constructors #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robjtede merged 1 commit into from
Nov 14, 2026
Merged

feat: deprecate infallible body stream constructors #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actix-web-lab/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Add `sse::Data::{retry, set_retry}` methods to set the connection's reconnection delay in individual data messages.
- Deprecate `body::{new_infallible_body_stream, new_infallible_sized_stream}` in favor of the upstream `actix_web::body::{BodyStream, SizedStream}::from_infallible()` constructors.

## 0.29.5

Expand Down
3 changes: 2 additions & 1 deletion actix-web-lab/src/body.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
//!
//! Analogous to the `body` module in Actix Web.

#[expect(deprecated)]
pub use crate::infallible_body_stream::{new_infallible_body_stream, new_infallible_sized_stream};
pub use crate::{
body_async_write::{Writer, writer},
body_channel::{Sender, channel},
infallible_body_stream::{new_infallible_body_stream, new_infallible_sized_stream},
};
12 changes: 10 additions & 2 deletions actix-web-lab/src/infallible_body_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ use crate::util::InfallibleStream;

/// Constructs a new [`BodyStream`] from an infallible byte chunk stream.
///
/// This could be stabilized into Actix Web as `BodyStream::from_infallible()`.
/// Use the upstream `actix_web::body::BodyStream::from_infallible()` constructor instead.
#[deprecated(
since = "0.29.6",
note = "Use the upstream `actix_web::body::BodyStream::from_infallible()` constructor instead."
)]
pub fn new_infallible_body_stream<S: Stream<Item = Bytes>>(
stream: S,
) -> BodyStream<InfallibleStream<S>> {
Expand All @@ -15,7 +19,11 @@ pub fn new_infallible_body_stream<S: Stream<Item = Bytes>>(

/// Constructs a new [`SizedStream`] from an infallible byte chunk stream.
///
/// This could be stabilized into Actix Web as `SizedStream::from_infallible()`.
/// Use the upstream `actix_web::body::SizedStream::from_infallible()` constructor instead.
#[deprecated(
since = "0.29.6",
note = "Use the upstream `actix_web::body::SizedStream::from_infallible()` constructor instead."
)]
pub fn new_infallible_sized_stream<S: Stream<Item = Bytes>>(
size: u64,
stream: S,
Expand Down
Loading