Use absolute URLs for cross-site nav links - #7
Open
siavashzaid wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR but I don't think that we want this. AcouPipe and the blog will soon be absorbed into acoular.org. We will do this asap once Adam is back. Then, all links should work cleanly leaving only Community to link to GitHub Discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_NAV_LINKSinacoular_sphinx/__init__.pyuses root-relative paths(
/acoular/,/spectacoular/,/contributing/) for the sharedorganization navbar. These only resolve correctly when the consuming
site is served from the domain root (
www.acoular.org). Any packagedocs hosted elsewhere — e.g. AcouPipe at
adku1173.github.io/acoupipe/— get 404s on those links.Change
Rewrites all
_NAV_LINKSentries to absolutehttps://www.acoular.org/...URLs, matching how
AcouPipe,Blog, andCommunityare alreadydefined.
Impact
Consumers currently working around this by rewriting nav links in
their own
conf.py(e.g. AcouPipe) can drop that workaround once theybump to the release containing this change.