build!: require Rust 1.97 for v0.8.0#523
Conversation
- align MSRV metadata, tooling, and documentation with Rust 1.97 - adopt the stabilized Hilbert highest-bit helper - apply new Clippy and rustdoc diagnostics and finish assertion cleanup - clarify the predicate benchmark workload and cold-path audit evidence BREAKING CHANGE: The minimum supported Rust version is now 1.97.0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe repository’s MSRV and pinned toolchain move from Rust 1.96.0 to 1.97.0. Documentation, CI workflows, benchmarks, rustdoc links, assertions, Hilbert bit handling, bibliography metadata, and compatibility audit notes are updated. ChangesRust 1.97 MSRV and audit
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
🟢 Coverage 95.83% diff coverage · +0.03% coverage variation
Metric Results Coverage variation ✅ +0.03% coverage variation (-1.00%) Diff coverage ✅ 95.83% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (e6e22f6) 80246 73097 91.09% Head commit (b7c25ce) 80300 (+54) 73167 (+70) 91.12% (+0.03%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#523) 72 69 95.83% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
coderabbitai
Bot
added
breaking change
documentation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/dev/tooling-alignment.md`:
- Around line 395-396: Update the stabilization-version wording in the
assert_matches! migration note from “Rust 1.95 cleanup” to “Rust 1.96 cleanup,”
leaving the rest of the documentation unchanged.
In `@README.md`:
- Line 126: Update the Rust version prerequisite wording in README.md to state
that the minimum supported version is declared in Cargo.toml, while the exact
toolchain is pinned by rust-toolchain.toml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: d3c665ed-8407-4897-87b9-e204c34e1e19
⛔ Files ignored due to path filters (1)
papers/validation.pdfis excluded by!**/*.pdf
📒 Files selected for processing (14)
AGENTS.mdCargo.tomlREADME.mdbenches/cold_path_predicates.rsclippy.tomldocs/dev/tooling-alignment.mdjustfilerust-toolchain.tomlsrc/core/algorithms/pl_manifold_repair.rssrc/core/util/hilbert.rssrc/core/vertex.rssrc/lib.rssrc/topology/ridge.rssrc/topology/spaces/spherical.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 91.06% 91.09% +0.02%
==========================================
Files 88 88
Lines 80025 80079 +54
==========================================
+ Hits 72878 72948 +70
+ Misses 7147 7131 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
- Clarify that Cargo.toml declares the MSRV while rust-toolchain.toml pins the repository toolchain. - Cover typed PL-manifold repair errors, boundary candidate filtering, and invalid facet handles. - Refresh the validation paper artifact used by the Papers workflow.
- enforce cargo-audit failures and refresh CodeQL action pins - require valid mixed-scale geometry quality metrics - align tooling documentation and scientific citation metadata - regenerate the validation paper artifact
coderabbitai
Bot
added
bug
1 participant
BREAKING CHANGE: The minimum supported Rust version is now 1.97.0.
Closes #496