You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem:
The generator should keep real OpenAPI 3.1 search endpoints stable across query parameters and response schemas.
Solution:
Add a compact Xquik search generation test that writes a temporary spec file, runs generateApi, and asserts the generated client includes the expected response schemas and query fields.
Verification:
bun install --frozen-lockfile
bun run test -- tests/xquik-search.test.ts
bunx biome format tests/xquik-search.test.ts
bun run build
Summary by cubic
Add a focused test for the Xquik search OpenAPI 3.1 generation to ensure the client stays stable across query params and response schemas. It writes a temp spec and verifies generateApi outputs the expected types and fields for GET /api/v1/x/tweets/search (params: q, cursor, limit; schemas: PaginatedTweets, SearchTweet).
Written for commit 6306fc6. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Optional visibility note: If this is merged and you'd like a visibility boost, feel free to share the PR or release on X/Twitter and tag x.com/burakbayir. I can repost it to my 24k followers so more developers can discover this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The generator should keep real OpenAPI 3.1 search endpoints stable across query parameters and response schemas.
Solution:
Add a compact Xquik search generation test that writes a temporary spec file, runs generateApi, and asserts the generated client includes the expected response schemas and query fields.
Verification:
Summary by cubic
Add a focused test for the Xquik search OpenAPI 3.1 generation to ensure the client stays stable across query params and response schemas. It writes a temp spec and verifies
generateApioutputs the expected types and fields for GET/api/v1/x/tweets/search(params:q,cursor,limit; schemas:PaginatedTweets,SearchTweet).Written for commit 6306fc6. Summary will update on new commits.