feat!: Convert spec classes to records#889
Draft
kabir wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a significant refactoring of the v0.3 compatibility layer, primarily converting domain objects like Task, Message, and various SecurityScheme implementations from standard classes to Java records. This change necessitates updating method calls from getter-style to accessor-style across the entire module, including transport layers and test suites. The refactor also includes converting Part_v0_3 into a sealed interface, updating serialization logic in JsonUtil_v0_3, and adding no-args constructors to specific handlers to maintain CDI compliance. I have no feedback to provide as there were no review comments to assess.
This became apparent since in non-Quarkus environments you have to set a bunch of JVM flags, and also introduce default constructors, which in turn means making fields non-final. Additionally, added default constructors for some CDI beans to work in stricter CDI environments than Quarkus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This became apparent since in non-Quarkus environments you have to set a bunch of JVM flags, and also introduce default constructors, which in turn means making fields non-final.
Additionally, added default constructors for some CDI beans to work in stricter CDI environments than Quarkus