Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A REST task ID ending in
:subscribeor:cancelcan be confused with an action. Go'surl.PathEscapeleaves colons unescaped, soGetTaskforfoo:subscribecan send a subscription request. On the server, even a properly escaped request such asGET /tasks/foo%3Asubscribeis decoded before dispatch and incorrectly subscribes tofoo;POST /tasks/foo%3Acancelcan cancelfoo.Escape colons in GetTask IDs and distinguish literal action separators from encoded colons using the raw path segment before dispatch. Preserve encoded action characters and existing GET/POST subscription support. Add client and server regressions covering encoded and literal separators, double encoding, query strings and tenants.
Validation
go test ./...go test -race ./a2aclient ./a2asrvgo vet ./...golangci-lint run ./...(v2.11.4)git diff --checkLoopback tests used
NO_PROXY=localhost,127.0.0.1,::1.