Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When cancellation overlaps an execution that finishes in
INPUT_REQUIRED, the execution's event consumer can stop before it processes the cancellation events. This can happen either after the pipe closes or after a cancellation event is enqueued successfully but no consumer remains.CancelTaskthen reports that the task cannot be canceled even though the task is still interruptible.This is the non-terminal case left open by the earlier closed-pipe fix in #521 (related to #518).
Change
Validation
go test ./...go test -race ./internal/eventpipe ./internal/taskexec ./a2asrv ./integrations/executor/a2aacpINPUT_REQUIRED, followed by successfulCancelTaskand aCANCELEDGetTask; mixed consumed/unread artifacts and push delivery; and an execution that reachesCOMPLETEDbefore cancellation. They also check callback and cleanup counts.The original stream ends when execution reaches
INPUT_REQUIRED; the later cancellation result is returned byCancelTaskand visible throughGetTask.