refactor: UI/UX#47
Merged
Merged
Conversation
- add reusable KeyboardAwareModal primitive - support async confirmation, loading and validation - migrate common form modals to the new API - prevent duplicate submissions and redundant dismissals - remove unused TextInput and keyboard height hook - add modal and category form tests Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR:
This pull request introduces a major refactor of the
ColorPickerModalcomponent, replacing the previous implementation with a modern, accessible color picker powered by thereanimated-color-pickerlibrary. It also adds comprehensive tests, improves the flexibility of theRowcomponent, and enhances theToggleButtonwith a disabled state. Additionally, several dependency and style updates ensure better compatibility and UI consistency.Summary of most important changes:
Color Picker Modal Refactor and Enhancements
ColorPickerModalto use thereanimated-color-pickerlibrary, providing a circular color picker, HEX input, and improved accessibility, while removing the old accent color grid and manual validation logic. The modal now normalizes all colors to opaque HEX6 and synchronizes state on open/close.ColorPickerModal, covering color normalization, UI rendering, input handling, and contract behaviors.Dependency Updates
reanimated-color-pickeras a new dependency inpackage.jsonand updatedpnpm-lock.yamlaccordingly. [1] [2] [3] [4]UI Component Improvements
Rowcomponent to accepthorizontalSpacingandverticalSpacingprops for more flexible layout control.ToggleButtoncomponent to support adisabledstate, visually indicating and preventing interaction when disabled. [1] [2] [3]Style Adjustments
toolWrapper.cssto use a CSS variable for the bottom inset, improving compatibility with devices that have variable safe area insets. [1] [2]These changes collectively modernize the color picker experience, improve test coverage, and enhance UI flexibility and accessibility.