Skip to content

fix: PHPMD does not require schema validation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rutgerrademaker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: PHPMD does not require schema validation #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.0.4]
### Fixed
- Error: Failed to locate the main schema resource at 'https://pmd.sourceforge.io/ruleset_xml_schema.xsd'.
### Removed
- Schema validation for PHPMD.

## [3.0.3]
### Fixed
- When running GrumPHP on an environment with the Redis PHP extension installed, it errored with `The package
Expand Down
5 changes: 1 addition & 4 deletions config/default/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="Youwe/Global"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="Youwe/Global" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>Default / Fallback configuration for PHPMD rulesets.</description>

<!-- Taken from Global ruleset since we can't modify a referenced rule without overwriting it completely.
Expand Down
5 changes: 1 addition & 4 deletions config/drupal/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD rules for Drupal projects.</description>
<rule ref="./config/default/phpmd.xml" />

Expand Down
5 changes: 1 addition & 4 deletions config/magento2/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD rules for Magento 2 projects.</description>

<!-- Taken from Global ruleset since we can't modify a referenced rule without overwriting it completely.
Expand Down
5 changes: 1 addition & 4 deletions config/pimcore/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="https://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="https://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD rules for Pimcore projects.</description>

<!-- Taken from Global ruleset since we can't modify a referenced rule without overwriting it completely.
Expand Down
5 changes: 1 addition & 4 deletions phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD</description>
<rule ref="./config/default/phpmd.xml">
<exclude name="ShortVariable"/>
Expand Down
5 changes: 1 addition & 4 deletions templates/files/default/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD</description>
<!--<exclude-pattern>path/to/exclude/*</exclude-pattern>-->
<rule ref="./vendor/youwe/testing-suite/config/default/phpmd.xml" />
Expand Down
5 changes: 1 addition & 4 deletions templates/files/drupal/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD</description>
<!--<exclude-pattern>path/to/exclude/*</exclude-pattern>-->
<rule ref="./vendor/youwe/testing-suite/config/drupal/phpmd.xml" />
Expand Down
5 changes: 1 addition & 4 deletions templates/files/magento2/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD</description>
<!--<exclude-pattern>path/to/exclude/*</exclude-pattern>-->
<rule ref="./vendor/youwe/testing-suite/config/magento2/phpmd.xml" />
Expand Down
5 changes: 1 addition & 4 deletions templates/files/pimcore/phpmd.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<?xml version="1.0"?>
<ruleset name="PHPMD"
xmlns="http://pmd.sf.net/ruleset/1.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 https://pmd.sourceforge.io/ruleset_xml_schema.xsd">
<ruleset name="PHPMD" xmlns="http://pmd.sf.net/ruleset/1.0.0">
<description>PHPMD</description>
<!--<exclude-pattern>path/to/exclude/*</exclude-pattern>-->
<rule ref="./vendor/youwe/testing-suite/config/pimcore/phpmd.xml" />
Expand Down