Skip to content

FED-4777 Remove dart_style dep, fix builder AOT compilation #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greglittlefield-wf wants to merge 8 commits into
base: master
Choose a base branch
from
Open

FED-4777 Remove dart_style dep, fix builder AOT compilation #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81390d7
Remove dart_style dep and mirrors usage
greglittlefield-wf Jul 2, 2026
42efe6b
Tweak/fix manual formatting in builder to reduce diffs after removing…
greglittlefield-wf Jul 2, 2026
4c10605
Update checked-in generated code after removing dart_style
greglittlefield-wf Jul 2, 2026
56ae4c6
Update gold files with ./tool/update_gold_output_files.dart
greglittlefield-wf Jul 2, 2026
4c24191
Remove unused extensions and pub_semver
greglittlefield-wf Jul 2, 2026
f5b5cd2
Update formatting in tests to match
greglittlefield-wf Jul 2, 2026
5ad36d9
Work around build_runner bug preventing test runs in Dart 3
greglittlefield-wf Jul 2, 2026
0b7d43c
Add changelog entry
greglittlefield-wf Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# OverReact Changelog

## Unreleased
- Remove `dart:mirrors` usage in builder to fix AOT compilation used in newer build_runner versions
- Remove `dart_style` and `pub_semver` dependencies, remove generated code formatter step
- Generated code was already pretty well-formatted before it was passed to `dart_style`, and since consumers don't interact with generated code much, this should have very little impact.

## 5.6.2
- Analyzer plugin
- Fix startup error (AOT compilation) in Dart 3
Expand Down
67 changes: 13 additions & 54 deletions example/boilerplate_versions/dart2_only/basic_component1.over_react.g.dart
View file
Open in desktop

@greglittlefield-wf greglittlefield-wf Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: these changes are best reviewed commit-by-commit

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 16 additions & 59 deletions example/boilerplate_versions/dart2_only/basic_component2.over_react.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading