Handle client close errors on python 3.14#99
Merged
Merged
Conversation
95171c3 to
c1f7168
Compare
🤖 Augment PR SummarySummary: Adds a Python 3.14 compatibility workaround to prevent a Docker-SDK-triggered cleanup error when HTTP responses are finalized. Changes:
Technical Notes: The patch is gated by 🤖 Was this summary useful? React with 👍 or 👎 |
c1f7168 to
f1552a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility patch for Python 3.14 to suppress a specific
ValueErrorrelated to closed HTTP response file pointers, which can occur when using the Docker SDK. The patch is implemented invibepod/cli.pyand is thoroughly tested with new unit tests intests/test_cli.py.Python 3.14 compatibility patch:
_install_python314_http_client_flush_patchand_should_ignore_closed_http_response_flush_errorfunctions tovibepod/cli.pyto suppress the "I/O operation on closed file." error raised during HTTP response cleanup in Python 3.14. The patch is applied automatically at module import.http.clientandsysinvibepod/cli.pyto support the new patch logic.