Skip to content

Improve Gradle Setup#678

Closed
Kichura wants to merge 1 commit into
ViaVersion:mainfrom
Kichura:rs_fun
Closed

Improve Gradle Setup#678
Kichura wants to merge 1 commit into
ViaVersion:mainfrom
Kichura:rs_fun

Conversation

@Kichura
Copy link
Copy Markdown
Member

@Kichura Kichura commented May 16, 2026

  1. The basic cache provider is now used as the enhanced caching provider is proprietary and requires agreeing to Gradle's TOS,
  2. The stacktrace argument is now included in the build command,
  3. Gradle now retries downloading wrapper 3 times in a row with 1000 milliseconds (which doubles on each subsequent failure) before giving up entirely.

1. The basic cache provider is now used as the enhanced caching provider is proprietary and requires agreeing to Gradle's TOS,
2. The stacktrace argument is now included in the build command,
3. Gradle now retries downloading wrapper 3 times in a row with 1000 milliseconds (which doubles on each subsequent failure) before giving up entirely.
@Kichura Kichura added github_actions Pull requests that update GitHub Actions code gradle-wrapper Pull requests that update Gradle wrapper labels May 16, 2026
@Kichura Kichura requested a review from RaphiMC May 16, 2026 09:35
@RaphiMC
Copy link
Copy Markdown
Member

RaphiMC commented May 16, 2026

@Kichura Is the cache-provider change even needed? The cache is disabled, so changing the provider should have no effect

@Kichura
Copy link
Copy Markdown
Member Author

Kichura commented May 16, 2026

@Kichura Is the cache-provider change even needed? The cache is disabled, so changing the provider should have no effect

I included it because of the reason above and that it would automatically use that in case the cache-disabled boolean ever gets set to false at one point.

@RaphiMC
Copy link
Copy Markdown
Member

RaphiMC commented May 17, 2026

Merged the changes, except for the cache-provider because its not needed in this case

@RaphiMC RaphiMC closed this May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code gradle-wrapper Pull requests that update Gradle wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants