Skip to content

fix(Clickable): disabled hover state - #10205

Merged
d-suvorov-vk-team merged 1 commit into
masterfrom
dsuvorov/fix/Clickable/disabled-hover-state
Aug 19, 2026
Merged

d-suvorov-vk-team merged 1 commit into
masterfrom
dsuvorov/fix/Clickable/disabled-hover-state

Conversation

@d-suvorov-vk-team

Copy link
Copy Markdown
Contributor
  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

  1. Кликаем на кнопку и переводим кнопку в состояние disabled
  2. Уводим курсор
  3. Переводим кнопку в состояние disabled=false

ФР:
Наведение на кнопке осталось

ОР:
Наведение на кнопке пропало

Изменения

Обрабатываем disabled для hover

Release notes

Исправления

  • Tappable: состояние наведение сохранялось после disabled состояния

@d-suvorov-vk-team
d-suvorov-vk-team requested a review from a team as a code owner August 17, 2026 10:49
@github-actions github-actions Bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 426.53 KB (+0.04% 🔺)
JS (gzip) 131.63 KB (+0.03% 🔺)
JS (brotli) 108.57 KB (-0.07% 🔽)
JS import Div (tree shaking) 945 B (0%)
CSS 384.91 KB (0%)
CSS (gzip) 46.95 KB (0%)
CSS (brotli) 37.07 KB (0%)

@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

e2e tests

Playwright Report

@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit 52950db

@codecov

codecov Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.24%. Comparing base (4f914e1) to head (52950db).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10205   +/-   ##
=======================================
  Coverage   95.23%   95.24%           
=======================================
  Files         460      460           
  Lines       12519    12552   +33     
  Branches     4482     4491    +9     
=======================================
+ Hits        11923    11955   +32     
- Misses        596      597    +1     
Flag Coverage Δ
unittests 95.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/10205/52950db610d69985c59312e71b9a3977c487d3d7/pkg/@vkontakte/vkui/_pkg.tgz

Commit 52950db

Comment thread packages/vkui/src/components/Clickable/useState.tsx
@d-suvorov-vk-team
d-suvorov-vk-team merged commit 8f1773f into master Aug 19, 2026
31 checks passed
@d-suvorov-vk-team
d-suvorov-vk-team deleted the dsuvorov/fix/Clickable/disabled-hover-state branch August 19, 2026 12:09
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in VKUI Aug 19, 2026
@vkcom-publisher

Copy link
Copy Markdown
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 8.3-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 8.3-stable, выполните следующие действия:

  1. Создайте новую ветку от 8.3-stable и примените изменения используя cherry-pick
git fetch origin 8.3-stable
git checkout -b patch/8.3-stable/pr10205 origin/8.3-stable

git cherry-pick --no-commit 8f1773f5fcec21d6cc7da2f5c3c23831ec66ca6b
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 8.3-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/8.3-stable/pr10205
gh pr create --base 8.3-stable --title "patch(8.3-stable): pr10205" --body "- patch #10205"

@vkcom-publisher

Copy link
Copy Markdown
Contributor
✅ v8.3.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:tappable type:bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants