Fix ADC value truncation: remove erroneous >>= 2 bit shift#6
Open
kaklik wants to merge 1 commit into
Open
Conversation
Raw ADC values were right-shifted by 2 bits before being stored, silently reducing energy resolution to 14 bits despite the ADC hardware delivering full 16-bit values. Removed from both FW variants (USTDFF and MAVLink) so event_channel and histogram receive the full unmodified ADC output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raw ADC values were right-shifted by 2 bits before being stored, silently reducing energy resolution to 14 bits despite the ADC hardware delivering full 16-bit values. Removed from both FW variants (USTDFF and MAVLink) so event_channel and histogram receive the full unmodified ADC output.