[start_ursim] Offer updating g5 urcap - #543
Merged
Merged
Conversation
Before that change, the script would automatically pull the latest version putting it aside the currently existing one. That would have unexpected side-effects. With this change we check whether there is an externalcontrol urcap with a different version present already. In that case the user is prompted for updating it which will remove the old version.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 79.14% 79.06% -0.09%
==========================================
Files 115 115
Lines 6776 6801 +25
Branches 3000 3000
==========================================
+ Hits 5363 5377 +14
- Misses 1042 1051 +9
- Partials 371 373 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit c228b87. Configure here.
urrsk
approved these changes
Aug 3, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before that change, the script would automatically pull the latest version putting it aside the currently existing one. That would have unexpected side-effects.
With this change we check whether there is an externalcontrol urcap with a different version present already. In that case the user is prompted for updating it which will remove the old version.
Note
Low Risk
Changes only affect the local
start_ursim.shURCap download path for non-PolyScopeX URSim; no production robot or auth logic is touched.Overview
PolyScope 5 / CB3 URSim startup no longer downloads a newer
externalcontrol-*.jaralongside an existing jar when the resolved version file is missing. It now detects otherexternalcontrol-*.jarfiles inURCAP_STORAGEand asks whether to remove them and install the target version.A new
prompt_urcap_updatehelper drives that choice with a[y/N]prompt,URCAP_PROMPT_TIMEOUT(default 10s), and timeout behavior that keeps the installed URCap. Declining skips the download; accepting removes matching jars before/after a successfulcurlfetch.Bats tests cover the prompt (yes/no/empty/timeout) and
main -tflows for fresh install, decline, and accept.Reviewed by Cursor Bugbot for commit 8ee78ad. Bugbot is set up for automated code reviews on this repo. Configure here.