You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not to rope @jalessio into this 😃 , but v helpful critique of this Dockerfile. Will revisit and make edits (again, just should anyone find this of use):
"too many layers… consolidate all those multiline commands into a single RUN like you have for the GEO libraries. Also, running apt-get update and apt-get install in separate RUN commands is a bit of an anti-pattern for a Dockerfile"
"also, I think you’re doing the “cleanup” step too early in the process — you should so that at the end, since the apt commands you run for GEOS will just re-populate /var/lib/apt"
Thank you for contributing this and for incorporating the original review feedback, Kuan. UDST has resumed active maintenance and reviewed the historical PR.
This targets the obsolete master branch and describes a 2017 development environment, so the Dockerfile should not be adopted as current build or release infrastructure. If UrbanAccess still needs a container after its supported Python versions, dependencies, and CI are established, we will create a new minimal image from the maintained packaging configuration.
Tracked in #95. We are leaving this open during the initial triage and will resolve it with the broader branch and infrastructure cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, relates to Issue: #12
Dockerfile provides a clean, consistent environment for development and execution of library.
Making it available if desired. :)