Skip to content

Fix typos in messages.yml#1363

Open
crexlight wants to merge 1 commit into
TuxCoding:mainfrom
crexlight:main
Open

Fix typos in messages.yml#1363
crexlight wants to merge 1 commit into
TuxCoding:mainfrom
crexlight:main

Conversation

@crexlight
Copy link
Copy Markdown

@crexlight crexlight commented May 24, 2026

  1. "Only paid Minecraft allowed accounts are allowed to join this server" -> "Only paid Minecraft accounts are allowed to join this server"
  • Awkward wording; redundant "allowed"
  1. "GameProfile is already set be a paid account" -> "GameProfile is already set to be a paid account"
  • Missing preposition "to" (x2)
  1. "You may want change it?" -> "You may want to change it?"
  • Missing "to" in infinitive "to change"

Summary by CodeRabbit

  • Documentation
    • Improved grammar and wording in localization strings for authentication and account-related messaging to enhance user clarity.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

📝 Walkthrough

Walkthrough

This PR updates localization message strings in core/src/main/resources/messages.yml to correct wording and grammar in user-facing messages. Changes include removing duplicated phrasing from premium account gating messages (switch-kick-message, add-premium-other), fixing account existence check messaging (already-exists), and rewriting the auto-register guidance text for clarity. No message keys were added or removed; only string values were modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely summarizes the main change: fixing typos/grammar in the messages.yml localization file.
Description check ✅ Passed The description provides clear, specific details of the typo corrections made. However, it lacks a formal section structure matching the template and omits the 'Related issue' section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core/src/main/resources/messages.yml (1)

62-62: 💤 Low value

Consider changing the question mark to a period for grammatical consistency.

The infinitive fix (adding "to") is correct. However, "You may want to change it?" mixes a declarative statement with interrogative punctuation, which is grammatically unusual. For consistency with other messages in this file (which use declarative statements), consider changing the question mark to a period: "You may want to change it."

✏️ Proposed refinement
-auto-register: '&2Tried auto registering with password: &7%password&2. You may want to change it?'
+auto-register: '&2Tried auto registering with password: &7%password&2. You may want to change it.'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/src/main/resources/messages.yml` at line 62, Update the auto-register
message value for the "auto-register" key to end with a period instead of a
question mark; replace "You may want to change it?" with "You may want to change
it." so the string becomes '&2Tried auto registering with password:
&7%password&2. You may want to change it.' ensuring punctuation matches the
file's declarative style.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@core/src/main/resources/messages.yml`:
- Line 62: Update the auto-register message value for the "auto-register" key to
end with a period instead of a question mark; replace "You may want to change
it?" with "You may want to change it." so the string becomes '&2Tried auto
registering with password: &7%password&2. You may want to change it.' ensuring
punctuation matches the file's declarative style.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ce41a6f2-c07b-46e9-9a60-c86684865bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 9486138 and 392e1e2.

📒 Files selected for processing (1)
  • core/src/main/resources/messages.yml
📜 Review details
🔇 Additional comments (2)
core/src/main/resources/messages.yml (2)

25-25: LGTM!


33-33: LGTM!

Also applies to: 36-36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant