feat: widen tonic dependency to >=0.13, <0.15 to support tonic 0.14 - #77
feat: widen tonic dependency to >=0.13, <0.15 to support tonic 0.14#77mstyura wants to merge 1 commit into
Conversation
|
Any thoughts here @skos-ninja ? Happy to help with testing if needed |
|
@mstyura. Doesn't build. Needs one of the |
|
@palfrey could you please share what was exact command you've used to run build? |
|
I hit this in the middle of TraceMachina/nativelink#2487 so slightly fiddly to pull it out of there. OTOH, if you install #!/usr/bin/env rust-script
//! ```cargo
//! [dependencies]
//! ginepro = { git = "https://github.com/mstyura/ginepro", rev = "d08cdeff6300edfb46204b3b9fbde3f3355db35f", default-features = false }
//! ```
fn main() {
} |
|
Ah, I think the problem is my use of |
|
@palfrey have you been able to resolve using the current version of ginepro ? even by using the default-features i still encounter an issue due to the mismatch versions |
Nothing has changed on current ginepro releases. Using this branch everything is fine though. |
Fair enough i'll then probably switch to this branch then. I wonder what'd be the impact for the future as tonic has now moved to the gRPC repository. Thanks ! |
Support tonic 0.14 alongside 0.13
Addresses #68: Widens
ginepro'stonicrequirement to>=0.13, <0.15so downstream users can build against either 0.13 or 0.14.Changes
ginepro: widentonicto>=0.13, <0.15and drop theprostfeature (removed in 0.14; ginepro never used the prost codec, so it's a no-op on 0.13).shared_proto/tests: move to tonic 0.14, which splits prost codegen into separate crates (tonic-build->tonic-prost-build, plustonic-prost).tonic-0_13-checkjob that compilesgineproagainst the 0.13 lower bound, so both ends of the range are covered (0.14 via the existing test suite, 0.13 via this check).Verification
cargo check --workspace --all-featurespasses on 0.14.gineprocompiles clean against tonic 0.13.1 with bothtls-ringandtls-aws-lc.