feat(ui): per-activity optional secondary sidebar — News goes full-width#321
Merged
Conversation
…s full-width The VSCode-era layout forced a secondary sidebar onto every activity. News's sidebar was a single-row "All News" placeholder taxing 200-500px of width for nothing. SECTION_BY_KEY is now a Partial record: activities without an entry are sidebar-less — clicking them opens their default tab full-width. Sidebar-less items keep ActivityBar highlight but lose the re-click collapse toggle (collapsing a nonexistent column only dropped the highlight) and skip the mobile secondary drawer. Removes NewsSidebar and its only i18n key (news.allNews) in all four locales. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SECTION_BY_KEYis now aPartialrecord — activities without an entry are sidebar-less: clicking opens their default tab full-width (the mechanism Automation/Portfolio can reuse later if we decide to strip theirs too)NewsSidebar.tsxand its only i18n key (news.allNews) in all four localesTest plan
uitsc -b clean🤖 Generated with Claude Code