Skip to content

Fix makeDocHandleReactive output being affected when changing clone #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasbah merged 2 commits into from
Sep 11, 2026
Merged

Fix makeDocHandleReactive output being affected when changing clone #1479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc3f5e3
TEST: Case for solid-projection affected by clone
kasbah Sep 10, 2026
858f524
FIX: `makeDocHandleReactive` clones avoid sharing mutation
kasbah Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/frontend/src/api/document.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,12 @@ export function makeLiveDoc<Doc extends Document>(

/** Create a Solid Store that tracks an Automerge document. */
export function makeDocHandleReactive<T extends object>(handle: DocHandle<T>): T {
const init = handle.doc();

const [store, setStore] = createStore<T>(init);
const [store, setStore] = createStore<T>(structuredClone(handle.doc()));

const onChange = (payload: DocHandleChangePayload<T>) => {
// Use [`reconcile`](https://www.solidjs.com/tutorial/stores_immutable)
// function to diff the data and thus avoid re-rendering the whole DOM.
setStore(reconcile(payload.doc));
setStore(reconcile(structuredClone(payload.doc)));
};

handle.on("change", onChange);
Expand Down
14 changes: 14 additions & 0 deletions packages/frontend/src/api/document_store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,20 @@ describe("API document store", () => {
expect((await store.getHandle(draftRef)).tag).toBe("Err");
});

test("transaction drafts do not mutate source projections (automerge-repo#721)", async () => {
const { binder, schema } = await createFixtureWithSchema();

const { tx, draftDocs } = await binder.beginTransaction({ schema });
try {
draftDocs.schema.add(Type, { label: "Person" });

expect(draftDocs.schema.cellsOf(Type)).toHaveLength(1);
expect(schema.cellsOf(Type)).toHaveLength(0);
} finally {
tx.abort();
}
});

test("reverting a commit restores deleted rich text blocks", async () => {
const { schemaAutomergeHandle, store } = createFixture();

Expand Down