Update gaios deploy - #1390
Open
paulsonnentag wants to merge 6 commits into
Open
Conversation
Patchwork renamed the tool plugin's `supportedDataTypes` field to `supportedDatatypes`, so the CatColab tool registered but never matched its own datatype. The vite externals were stale in both directions: they named the removed `@patchwork/rootstock` and `@patchwork/context` packages, and they omitted `solid-js`, which Patchwork supplies through its importmap. Bundling a second Solid runtime breaks context lookups and click delegation against the host's copy, so take the list from `@inkandswitch/patchwork-bootloader/externals` rather than hand-maintaining it. This also shrinks the tool chunk from 13.1MB to 11.6MB. Bump pushwork to v2 so `pnpm push` can read the v5 `.pushwork/config.json` that current pushwork writes; the pinned v1 aborted with a config version mismatch. Record the plugin's document URL under `pushwork.url`, which is where Patchwork tools now keep it, and drop the unused react, uuid and `@patchwork/context` dependencies.
Register a catcolab-analysis datatype and tool in the gaios Patchwork plugin. The tool shows the model notebook and analysis notebook in two editable panes, resolving the model through the analysis's analysisOf reference. Analyses are created from a "New analysis" button in the model tool, since a blank analysis referencing no model would be useless (the datatype is unlisted for the same reason).
Analyses created from the model tool carried no @Patchwork metadata, so Patchwork could only resolve their tool via the explicit toolId in the open-document event. Set the datatype id and copy the plugin import URLs from the model so analysis docs are self-describing when opened by URL.
Opening a model in Patchwork now ensures a linked analysis document exists (created on first open, recorded in the model's analysisDocUrl field) and always renders the side-by-side model/analysis view, replacing the "New analysis" button.
Adds a build_gaios job that builds packages/gaios and uploads it shaped as a Patchwork package (package.json + dist), and deploys it under /gaios/ on Netlify with permissive CORS so Patchwork shells (e.g. GaiOS) can load the plugin by URL instead of vendoring the build.
Contributor
Author
|
Is there a way to get a build preview? It would be nice if we could test that the deployed version is loadable in gaios before we merge this |
Member
|
Probably best if we add you as a contributor but I'll leave that up to @epatters . I copied your branch for now: #1393 The build passed: https://github.com/ToposInstitute/CatColab/actions/runs/31703563860/artifacts/9182366436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to add CatColab as a default tool in gaios.sgai.uk. At the moment we check a bundled copy of CatColab into the gaios.sgai.uk repo, which means it goes stale as soon as you ship a new version. It would be much nicer to hook into your existing deploy workflow so that each CatColab release also uploads a bundle to Netlify that gaios can load directly.
This PR contains: