Skip to content

UI for editing path equations in schemas and ologs - #1247

Open
kasbah wants to merge 4 commits into
mainfrom
kb/equations-ui
Open

UI for editing path equations in schemas and ologs#1247
kasbah wants to merge 4 commits into
mainfrom
kb/equations-ui

Conversation

@kasbah

@kasbah kasbah commented May 5, 2026

Copy link
Copy Markdown
Member

Following on from #1061 this is the editing UI for equations. Closes #63 .

@kasbah
kasbah force-pushed the kb/equations-ui branch 5 times, most recently from 81ae0c4 to bc8e19f Compare May 8, 2026 12:34
@kasbah
kasbah marked this pull request as ready for review May 8, 2026 12:47
@kasbah
kasbah requested review from KevinDCarlson and epatters May 8, 2026 12:47
@kasbah

kasbah commented May 8, 2026

Copy link
Copy Markdown
Member Author

I could use some help formulating some brief statements about this to put into the logics docs.

KevinDCarlson

This comment was marked as outdated.

@kasbah

This comment was marked as outdated.

@kasbah
kasbah force-pushed the kb/equations-ui branch from bc8e19f to 3b18fd0 Compare May 12, 2026 14:14
@kasbah
kasbah requested a review from jmoggr as a code owner May 12, 2026 14:14
@kasbah
kasbah force-pushed the kb/equations-ui branch from 0cb1520 to 09c2154 Compare May 12, 2026 14:43
@KevinDCarlson

This comment was marked as outdated.

@epatters epatters added enhancement New feature or request frontend TypeScript frontend and Rust-wasm integrations labels May 12, 2026
@kasbah
kasbah force-pushed the kb/equations-ui branch 2 times, most recently from 54b86b8 to d4fc199 Compare May 15, 2026 18:51
@kasbah
kasbah force-pushed the kb/equations-ui branch from d4fc199 to 3dc3c2b Compare May 28, 2026 16:17

@epatters epatters left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kaspar! While this isn't a code review, I'm recording a few problems I noticed while testing.

  1. Cosmetic issue: the vertical alignment of "E" in the bottom path is off:

    Image
  2. Another cosmetic issue: the vertical sizing of "E" in the popover is off:

    Image
  3. Logic issue: it is not currently possible to build path with repeat edges:

    Image

This is important because in practice a path in a path equation often uses the same generating morphism twice. In this example (the schema for symmetric graphs), I am trying to express that "inv" is indeed an involution, i.e., composing it with itself gives the identity.

@kasbah
kasbah force-pushed the kb/equations-ui branch from 3dc3c2b to 9f04cb9 Compare June 15, 2026 17:19
@kasbah
kasbah force-pushed the kb/equations-ui branch from 9f04cb9 to e4b64ba Compare June 24, 2026 17:55
@kasbah
kasbah changed the base branch from main to kb/list-editor-improvements June 24, 2026 17:56
@kasbah

kasbah commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

I changed the approach completely to allow for repetition. It now uses the list editor to form paths and is based on #1326 .

@kasbah
kasbah force-pushed the kb/equations-ui branch 3 times, most recently from 8b8e9a3 to d269054 Compare June 26, 2026 15:43
@kasbah
kasbah force-pushed the kb/list-editor-improvements branch from b7f8097 to b573217 Compare June 26, 2026 15:43
@kasbah
kasbah force-pushed the kb/equations-ui branch from d269054 to a09397c Compare June 26, 2026 15:44
Base automatically changed from kb/list-editor-improvements to main July 6, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend TypeScript frontend and Rust-wasm integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor for path equations in models

3 participants