[kasbah]

Following on from #1061 this is the editing UI for equations. Closes #63 .

[kasbah]

I could use some help formulating some brief statements about this to put into the logics docs.

[epatters]

Thanks Kaspar! While this isn't a code review, I'm recording a few problems I noticed while testing.

1. Cosmetic issue: the vertical alignment of "E" in the bottom path is off:

   

2. Another cosmetic issue: the vertical sizing of "E" in the popover is off:

   

3. Logic issue: it is not currently possible to build path with repeat edges:

   

This is important because in practice a path in a path equation often uses the same generating morphism twice. In this example (the schema for symmetric graphs), I am trying to express that "inv" is indeed an involution, i.e., composing it with itself gives the identity.

[kasbah]

I changed the approach completely to allow for repetition. It now uses the list editor to form paths and is based on #1326 .

[epatters]

Thanks for the ping, and sorry that this sat for so long. I'd love to get this in as it will pair nicely with the new data features. I'll re-review this PR tomorrow.

[epatters]

This is awesome. Check out my schemas:

A few small comments below related to the helper functions.

Relatedly, I wonder about the helpers to (de)construct identities and composites: I didn't comment on these specifically but I'm imagining that these will be subsumed by the TS API for models. Is that right?

[kasbah]

Thanks, I believe I addressed everything.

identities and composites: I didn't comment on these specifically but I'm imagining that these will be subsumed by the TS API for models. Is that right?

I haven't thought about these in that context yet but I probably should.

Review is now stale.