Repository navigation
test: drop the xfail markers from two handle-visibility tests that pass - #672
Merged
Merged
Conversation
TestPreStartIndicator and TestPostEndIndicator each mark test_display_as_deselected_with_selected_descendant xfail with "feature not reimplemented", but both have passed for a while: a deselected hierarchy with one selected descendant already hides its own handle. The markers only made the suite report XPASS every run. Their two-selected-descendant siblings still fail, so those keep the marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPreStartIndicatorandTestPostEndIndicatorintests/ui/timelines/hierarchy/test_hierarchy_ui.pyeach marktest_display_as_deselected_with_selected_descendantas xfail ("feature not reimplemented"), but both pass: a deselected hierarchy with one selected descendant already hides its own handle. The markers only made the suite report XPASS on every run.Their two-selected-descendant siblings still fail, so those keep the marker.