fix: ignore stale YouTube duration reports#557
Merged
Conversation
…ideo getDuration() is queried asynchronously on each UNSTARTED player-state transition. Opening a second YouTube-backed file reuses the same YouTubePlayer/QWebEngineView instance (media type unchanged, so _change_player_type never tears it down), so a query issued for the first video can resolve after the second has already loaded, silently overwriting App.duration with a value that belongs to the wrong video. Thread the video_id the query was issued for through the callback chain and discard results that no longer match the currently loaded video.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDuration() is queried asynchronously on each UNSTARTED player-state transition. Opening a second YouTube-backed file reuses the same YouTubePlayer/QWebEngineView instance (media type unchanged, so _change_player_type never tears it down), so a query issued for the first video can resolve after the second has already loaded, silently overwriting App.duration with a value that belongs to the wrong video.
Thread the video_id the query was issued for through the callback chain and discard results that no longer match the currently loaded video.