fix: comments icon no longer blocks dragging hierarchy handles - #553
Merged
azfoo merged 2 commits intoJul 20, 2026
Merged
Conversation
FelipeDefensor
commented
Jul 2, 2026
FelipeDefensor
commented
Jul 2, 2026
The hierarchy comments icon (z = level + 1) stacked above the body drag handles (z = 0). QGraphicsView.itemAt returns the topmost item, and the comments emoji's bounding box overhangs the handle x (notably wide on macOS), so clicks near a boundary resolved to the icon — which is not a left_click_trigger — so the boundary could not be dragged. Adjacent units carrying comments (e.g. S/R/D sections) buried every internal boundary handle. Raise drag handles above the decorative overlays so they always win the hit-test. Handles were already above all bodies, so only handle-vs-icon stacking changes.
FelipeDefensor
force-pushed
the
fix/comments-icon-overlays-handles
branch
from
July 2, 2026 14:52
7965ce1 to
8e3ac31
Compare
FelipeDefensor
marked this pull request as ready for review
July 2, 2026 14:58
loop box z-level would have been higher than the lowest hierarchy if the user used more hierarchy levels than the number of default colours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments indicator on adjacent hierarchy units sat on top of the body drag handles, making those boundaries impossible to drag. Reported on macOS; the glyph is narrower on Windows, so it may not reproduce there.
Cause: the comments icon has
z = level + 1, above the drag handles'z = 0. Click dispatch usesQGraphicsView.itemAt, which returns the topmost item — and the icon's bounding box overhangs the handle's x, so clicks resolved to the icon, which isn't a drag trigger.Fix: raise the drag handles above the decorative overlays (
HANDLE_Z = 100) so they always win the hit-test. Handles were already above all bodies, so only handle-vs-icon stacking changes. Also covers the loop icon's matching overlap with the start handle.Added a regression test asserting the comments icon stacks below both handles.