Skip to content

typing: fix invalid-assignment errors - #15433

Closed
peeyushtiwary27 wants to merge 3 commits into
TheAlgorithms:masterfrom
peeyushtiwary27:fix-invalid-assignment
Closed

peeyushtiwary27 wants to merge 3 commits into
TheAlgorithms:masterfrom
peeyushtiwary27:fix-invalid-assignment

Conversation

@peeyushtiwary27

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or type issue in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

This PR fixes the remaining invalid-assignment diagnostics reported by ty.

Changes:

  • Fix pixel assignment in computer_vision/mean_threshold.py.
  • Add type annotations for Dancing Links node attributes in other/dancing_links.py.
  • Introduce a generic SortFunction protocol for sorts/benchmark_sorts.py.

Validation:

  • ty check --exclude-scripts reports no invalid-assignment errors.
  • pytest -q tests/test_sorts.py → 359 passed.
  • git diff --check passes.

Part of #15187

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 24, 2026
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Sep 24, 2026
@cclauss

cclauss commented Sep 24, 2026

Copy link
Copy Markdown
Member

Three different algorithm files were modified. Please rebase master before creating a pull request.

@cclauss cclauss closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants