ci(devcontainer): Debian 13 Trixie + Python 3.14, modernize VS Code settings, drop .vscode - #15160
Conversation
…S Code settings, drop .vscode
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first. Invalid files in this pull request: |
|
Heads-up: @cclauss — same situation as #15157, which you reopened; could you reopen this one too (I don't have the permission)? If you'd rather avoid the Dockerfile entirely, I can drop that hunk and set the base image purely via |
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first. Invalid files in this pull request: |
Closing this pull request as invalid@priya-sundaram-dev, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first. Invalid files in this pull request: |
|
This is a massive bummer because you created TheAlgorithms/algorithms-keeper#228 (can you add Dockerfile to that PR), but neither @poyea nor I have permission to merge it. We NEED help from @dhruvmanila, @AnupKumarPanwar, or @dynamitechetan to merge that. In the meantime, is there a way to disable algorithms-keeper on this repo? Can you please recreate this PR without the changes to the Dockerfile, and then I will make those separately? In this PR, can we specify free-threaded Python 3.14t instead of 3.14?? |
Describe your change:
Modernizes the
.devcontainer/configuration as requested in #15081, plus a recommendation on.vscode/.Base image — Debian 13 "Trixie" + latest CPython
VARIANT:3.13-bookworm->3.14-trixie(Debian 13 Trixie, Python 3.14 = current latest-stable CPython).mcr.microsoft.com/vscode/devcontainers/pythonto the currentmcr.microsoft.com/devcontainers/python.3.11-trixie...3.14-trixie) — there is currently no floating3-trixiealias (the bare3tag still resolves to3-bookworm). So to get both Trixie and the newest interpreter I pinned3.14-trixie; the comment tells future maintainers to bump it when a newer stable ships.Free-threaded CPython &
.python-versionYou asked whether we can pull the latest free-threaded build, or have the devcontainer read
.python-version. Two honest constraints:t) variants, so there's no3.14t-style tag to pointVARIANTat.devcontainer.jsonbuild.argsare not templated — they can't read.python-versionat build time.The clean bridge is the tool we already standardize on: uv reads
.python-version..python-versionis3.14t, souv sync/uv runinside the container will provision and use free-threaded 3.14t regardless of the base image's interpreter. I addeduvto the Dockerfile'spipx installso it's ready out of the box — contributors get free-threaded 3.14t viauv runwithout us needing a non-existent free-threaded base tag.VS Code settings modernization
python.linting.*andpython.formatting.blackPath/mypyPathsettings (the Python extension no longer honors these; linting/formatting moved to dedicated extensions).charliermarsh.ruff) and wired format-on-save +source.fixAll/organizeImportsfor[python], matching the repo's actual linter/formatter..vscode/recommendationThe directory held a single setting —
githubPullRequests.ignoredPullRequestBranches: ["master"]— which is a personal convenience for the VS Code GitHub-PR extension, not project tooling. Since pre-commit + Ruff already cover formatting/linting for everyone, I went with your inclination and deleted.vscode/in this PR. It's a genuine judgment call, though: if you'd rather keep that one line so the PR extension doesn't treatmasteras a reviewable branch, I'm happy to restore just that file.@cclauss — happy to split any of these (base bump / settings /
.vscodedelete) into separate PRs if you'd prefer smaller units.Checklist: