Skip to content

Replace zustand with jotai#167

Draft
rtritto wants to merge 7 commits into
TexteaInc:mainfrom
rtritto:replace-zustand-with-jotai
Draft

Replace zustand with jotai#167
rtritto wants to merge 7 commits into
TexteaInc:mainfrom
rtritto:replace-zustand-with-jotai

Conversation

@rtritto

@rtritto rtritto commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented Jan 14, 2023

Copy link
Copy Markdown

Deploy Preview for any-viewer failed.

Name Link
🔨 Latest commit 73e6be0
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/6417b56763cd9b000818ddf2

@rtritto

rtritto commented Jan 14, 2023

Copy link
Copy Markdown
Contributor Author

Is needed some help to review and test

FYI @himself65

@rtritto rtritto mentioned this pull request Jan 14, 2023
6 tasks
@rtritto
rtritto marked this pull request as ready for review January 15, 2023 00:39
@rtritto
rtritto marked this pull request as draft January 15, 2023 01:06
@pionxzh

pionxzh commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

@rtritto Sorry that we did a rebasing to remove sensitive content from the history last week.
And now the history is messed up 😢

I would like to check with you on the plan for this PR. I have migrated zustand to adopt the V4 API.

And if you want, I can help you rebase to the correct state.

@rtritto

rtritto commented Mar 19, 2023

Copy link
Copy Markdown
Contributor Author

@pionxzh I will try the rebase.

@rtritto
rtritto force-pushed the replace-zustand-with-jotai branch from 9ea41b8 to 97ba10e Compare March 20, 2023 01:21
@rtritto
rtritto force-pushed the replace-zustand-with-jotai branch from 97ba10e to 73e6be0 Compare March 20, 2023 01:22
@rtritto

rtritto commented Mar 20, 2023

Copy link
Copy Markdown
Contributor Author

@pionxzh rebased.
When all tests are fixed, I can update jotai to v2.

@pionxzh

pionxzh commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

Thanks. I will spend some time checking this today. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants