feat(auth): redesign the email verification screen - #327
Merged
Conversation
Result screens were each rebuilding the same centred column from scratch, and drifting: the email verification screen used bodyMedium for its headline and a 200dp button cap where the register success screen used titleLarge and 300dp. ResultLayout fixes the shape once — badge, headline, body, hint, actions — and scrolls rather than centring rigidly, so the content survives landscape and short windows. ResultBadge takes the icon as a parameter so artwork stays in the features.
The screen ends two flows the user cares about — creating an account and upgrading a guest — but rendered as a top-left block of bodySmall text with no way to tell the outcomes apart beyond one tinted line. It now uses ResultLayout, so it centres, scrolls and matches the type scale of the other result screens. A third case also lands here: a registered user confirming an email change. It reused the fresh-registration copy and never explained that the session had been ended on purpose. All three now say what actually happened, driven by a VerificationOrigin read from the cached session before the token is spent — the server returns no body, so the account on the device is the only signal. The origin is published before the request rather than after it so the failure state can use it too: the screen only holds a token and cannot resend anything, but it can name the place that can, and that place differs per flow. isVerifying/isVerified/retainsSession collapse into that origin plus a status; retainsSession was only ever origin == Guest.
Continue popped the verification screen and uncovered Home, which the deep link had seeded underneath it. The upgrade starts on Profile and is only visible there — the guest banner and the upgrade row are gone — so it now lands back where it began. Left as the default for the logged-out graph, which cannot reach this outcome: with no account on the device the token can only be finishing a registration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.