fix(tests): pass required --update-weight-local-checkpoint-dir in ext…#2177
Open
MengsD wants to merge 1 commit into
Open
fix(tests): pass required --update-weight-local-checkpoint-dir in ext…#2177MengsD wants to merge 1 commit into
MengsD wants to merge 1 commit into
Conversation
…ernal_pd delta test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: test_qwen3_4B_external_pd.py
af3d7ff ("Disk-level delta weight sync", #2089) made
--update-weight-local-checkpoint-dir"Required for --update-weight-mode=delta--update-weight-transport=disk" in slime/utils/arguments.py, but did not update
test_qwen3_4B_external_pd, which still builds delta_args without it. The test
aborts at arg validation:
ValueError: --update-weight-mode=delta requires --update-weight-local-checkpoint-dir
Add a dedicated tempdir for the rollout-host-local checkpoint and pass it,
mirroring the existing delta_dir handling; clean it up alongside delta_dir