(fix): handle none/dict rewards in _compute_zero_std_metrics#2157
Open
atoniolo76 wants to merge 2 commits into
Open
(fix): handle none/dict rewards in _compute_zero_std_metrics#2157atoniolo76 wants to merge 2 commits into
atoniolo76 wants to merge 2 commits into
Conversation
….py. Add unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OPD or multi-turn cases, the
sample.rewardcan come back as None or a dict of teacher log probs.The _compute_zero_std_metrics function returns 1 if all samples in a group have the same reward, 0 otherwise. If a sample is aborted (common in multi-turn training) and
sample.rewardisNone, Slime fails withTypeError: type NoneType doesn't define __round__ methodat theround()call ininteresting_rewards. For OPD, thesample.rewardmay be a customdictcontaining a payload of teacher log probs forpost_processto handle. This function intercepts the reward and fails with the sameTypeError: type dict doesn't define __round__ method. Note that the original failure mode only happens when a group of rewards are allNoneor contain adict. Now, when any rewards areNoneordict,_is_zero_stdis not run for the whole group.To reproduce:
Will fail with
# TypeError: type NoneType doesn't define __round__ method