fix(e2e): give component lookups room for cold-start player creation - #896
Closed
tvanlaerhoven wants to merge 1 commit into
Closed
fix(e2e): give component lookups room for cold-start player creation#896tvanlaerhoven wants to merge 1 commit into
tvanlaerhoven wants to merge 1 commit into
Conversation
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
deleted the
devin/1786485825-e2e-cold-start-waittime
branch
August 11, 2026 22:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e
<Tester>never setwaitTime, sospec.findComponent('Scene.player')— every spec'sfirst step, via
preparePlayerWithSource()— gave up after cavynext's default 2000 ms:The player is only registered in the hook store from
onPlayerReady, and on an iOS/tvOSsimulator the first
onPlayerReadyafter app launch takes 3–9 s (measured across recentruns of #893: 3.2 s, 3.5 s, 4.5 s, 6.0 s, 8.9 s; Android is 0.3 s because its e2e app is built
--mode release, while iOS/tvOS run Debug off Metro). So the first player-dependent test(s) ofa run raced player creation and failed with
and passed on retry — the flakiness that is "mostly iOS, sometimes Android".
waitTimeis onlyan upper bound on the polling loop (100 ms interval), so a generous value costs nothing once the
player is registered; the run with 8.9 s of cold start is comfortably inside 30 s.
Two things this does not fix, both in cavynext itself and patched separately:
WebSocketReporter.sendData()drops every event while the socket is stillCONNECTING, sothe
❌ … Caught error: …line of exactly these early failures never reaches the log — whichis why the run summary reported failures while the log showed only green ticks. Symptom
visible in every job:
cavynext test suite started at …is missing from all 21 logsinspected, and printed results are always fewer than
N examples(even green Android/web runsprint 27 of 28).
Player error … errorCode 5003on "Set mp4 … dispatches a seeked event after seeking", andExpected true to be falsyon "… paused, play and playing events after pausing & resuming".Link to Devin session: https://dolby.devinenterprise.com/sessions/9cbd83149afa4521a7b0cdfbb9b09118
Requested by: @tvanlaerhoven