Repository navigation
Migrate e2e tests from cavy to react-native-cavynext, add web e2e support #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
f5aaf90
Migrate e2e tests from cavy/cavy-cli to react-native-cavynext.
tvanlaerhoven 91bf916
Resolve react-native-cavynext from its GitHub repo via a submodule.
tvanlaerhoven ad44f93
Use github#dist branches for react-native-cavynext dependencies.
tvanlaerhoven 8b708ff
Bump react-native-cavynext dist pins for the modernised spec API.
tvanlaerhoven 399b5e4
Modernise the e2e specs and add web test support.
tvanlaerhoven 0214d18
Player test layer on cavynext: hook-store player, robust event waits.
tvanlaerhoven aa347b7
Use the published npm packages for react-native-cavynext.
tvanlaerhoven a7a338d
Regenerate the e2e lockfile after rebasing on develop (RN 0.86.2)
tvanlaerhoven 4088089
Run the web e2e tests on PRs.
tvanlaerhoven 92bdd10
Remove unused react-native-device-info from the e2e app.
tvanlaerhoven 58da9f5
Pass --markdown to the Android and iOS e2e runs.
tvanlaerhoven 14745f5
Allow extra time for cold-start e2e player
devin-ai-integration[bot] 9111949
Bind player callbacks in TestableApp
3c06819
Fix web e2e browser cleanup, bind player callbacks, drop stray .gitmo…
devin-ai-integration[bot] c2ae75f
Fail loudly when no browser is found for the web e2e run
devin-ai-integration[bot] 6b9ce11
Use describe.each for the source-parameterized e2e specs.
tvanlaerhoven 09d7939
Enable the connector e2e tests.
tvanlaerhoven edd1ad3
Add the Nielsen specs repo to the e2e Podfile
tvanlaerhoven d30e597
Scope the PR workflow path filters per platform
tvanlaerhoven 6a0a9e0
Update e2e/scripts/run_web_e2e.sh
tvanlaerhoven 7a694ed
Update .github/workflows/pr_web.yml
tvanlaerhoven 1e29551
Rewrite the Nielsen framework name for the tvOS e2e target
devin-ai-integration[bot] 0c6197f
Drop StrictMode and ad sources from the e2e presentation mode tests
devin-ai-integration[bot] 1fac8be
Log the paused state on play, playing and pause in the e2e test app
devin-ai-integration[bot] 7e539aa
Clear the paused state on play and settle a new player before use
devin-ai-integration[bot] 6de1de9
Add a changelog entry for the paused state fix
devin-ai-integration[bot] 76c2afa
Merge branch 'develop' into feature/cavynext-migration
devin-ai-integration[bot] 210fe29
Use a small mp4 test source to avoid aborted progressive downloads
devin-ai-integration[bot] 6a32fa8
Fail the web e2e run when the dev server does not come up
devin-ai-integration[bot] 3bb792d
Include the ad payload in the e2e ad error message
devin-ai-integration[bot] 69aae67
Run the e2e ad tests on a single source and retry a failed ad break
devin-ai-integration[bot] 6467bb9
Drop the non-existent web/** path filter from the web PR workflow
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| console.error('This app can only be used with cavy-cli'); | ||
| console.error('This app can only be used with react-native-cavynext-cli'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { AppRegistry } from 'react-native'; | ||
| import { TestableApp } from './src/TestableApp'; | ||
| import { name as appName } from './app.json'; | ||
|
|
||
| AppRegistry.registerComponent(appName, () => TestableApp); | ||
|
|
||
| // On web the application has to be started explicitly. | ||
| AppRegistry.runApplication(appName, { | ||
| rootTag: document.getElementById('app'), | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| // The plain web entry point. The e2e app is only meaningful when run through | ||
| // `cavynext run-web`, which swaps `index.test.web.js` into this place. | ||
| console.error('This app can only be used with react-native-cavynext-cli: run `npm run test:e2e:web`.'); | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.