Waveform denoising: separate module / add option in compute motion / and sparse localization#4706
Draft
alejoe91 wants to merge 18 commits into
Draft
Waveform denoising: separate module / add option in compute motion / and sparse localization#4706alejoe91 wants to merge 18 commits into
alejoe91 wants to merge 18 commits into
Conversation
alejoe91
added
sortingcomponents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates creates the
sortingcomponents/waveforms/denoisingsubmodule and includes a multi-method interface for denoising.In addition the PR includes:
WaveformTransformernode is used to construct nodes that return a new version of waveforms.denoise_kwargsand denoise step in motion computation/correctionExtractSparseWaveformsThe last point makes it possible to run the 1d CNN denoiser from IBL for motion correction in about the same time as the normal motion correction! The sparsification of the waveforms is done at extraction rather than at localization, so the denoiser node has fewer channels to denoise!
Incorporates changes form #4673