Fix loading via 3rd party mod on 1.17+ forge - #19
Open
Sychic wants to merge 30 commits into
Open
Conversation
Sychic
force-pushed
the
feat/mixin-bootstrap
branch
from
June 18, 2024 22:08
6a409b6 to
bf68f44
Compare
Sychic
force-pushed
the
feat/mixin-bootstrap
branch
from
June 18, 2024 22:09
bf68f44 to
329bbd8
Compare
Sychic
marked this pull request as ready for review
June 18, 2024 22:14
… only" This reverts commit aef0ceb.
this should reduce issues where the file system may prevent the file move from happening. F.ex. cross file systems, or file being open due to the stream.
Sychic
force-pushed
the
feat/mixin-bootstrap
branch
from
August 24, 2024 19:16
9bf0693 to
2955dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the transformation service system prevented the loader from being included in third party mods. The origin of this comes from forge being unable to load jars with transformation services as mods. Despite our workaround to force load the source of the transformation service as a mod, forge then loads the stage0 package twice (once from loading as a transformation service, twice from being loaded as a mod).
This system circumvents this by bootstrapping the loading process via a Mixin config plugin. In stage 2, a pinned jar is downloaded to the mods folder and the user is prompted to restart.