Skip to content

Update ruling results for PR #6913#6914

Open
github-actions[bot] wants to merge 1 commit intoimprovement/s6842-use-upstream-recommended-allowlistfrom
fix/update-ruling-for-improvement/s6842-use-upstream-recommended-allowlist
Open

Update ruling results for PR #6913#6914
github-actions[bot] wants to merge 1 commit intoimprovement/s6842-use-upstream-recommended-allowlistfrom
fix/update-ruling-for-improvement/s6842-use-upstream-recommended-allowlist

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Auto-generated ruling update for PR #6913.

🤖 Generated with GitHub Actions

🤖 Generated with GitHub Actions
@sonar-review-alpha
Copy link
Copy Markdown
Contributor

sonar-review-alpha Bot commented Apr 24, 2026

Summary

This PR auto-generates test expectation updates for rule S6842 following implementation changes in the base PR (#6913). The TypeScript test expectations file is updated to remove one violation that is no longer flagged after expanding the rule's allowlist. Specifically, the violation at line 215 in vertical-segmented-control.tsx is removed, while the violation at line 71 in segmented-item.tsx is retained.

What reviewers should know

What to check:

  • Verify that the removed violation in vertical-segmented-control.tsx is correctly no longer flagged by the new rule logic
  • Compare against the base PR (JS-1654 Align S6842 with upstream jsx-a11y recommended allowlist #6913 / branch improvement/s6842-use-upstream-recommended-allowlist) to confirm the allowlist expansion is intentional
  • Check that retained violations still match the rule's new behavior

Files:

  • Only its/ruling/src/test/expected/desktop/typescript-S6842.json is modified — a test expectations file, not implementation code

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown
Contributor

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants