Assume port 443 instead of 80 for https origins.#35
Merged
jondubois merged 1 commit intoJan 24, 2019
Merged
Conversation
The Origin check was assuming that an Origin header with no port number means port 80, even if the scheme is https. Instead, if the Origin header doesn't contain a port, assume port 443 if the scheme is https and port 80 otherwise.
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can enable checking of the Origin header using the
originsoption tonew SocketCluster, e.g.However, this fails if the Origin header scheme is https and the header contains no port, e.g.
The check fails because if the header contains no port, the port defaults to 80, regardless of the scheme. This pull request changes the check to assume port 443 if the Origin header contains no port and the schema is https; otherwise, continue to assume port 80.