Upgrade ws to support maxPayload#32
Merged
Merged
Conversation
Member
|
@zalmoxisus I published this to npm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see there's
maxPayloadintroduced insocketclusterhere, but it's not supported bysc-uws. Inwsthe support was added from6.0.I have an issue where some clients are sending payloads which exceed RAM limit of heroku dyno and it's crashing the instance. This option looks like a solution without adding nginx.
EDIT: Merging this is not a top priority as we can just copy ws locally and specify the path in
wsEngineoption. I checked it doesn't look to break anything, but still might be kept for a major release.